Skip to content

feat(force-value) - improve to use form description component#984

Merged
gabrielseco merged 4 commits intomainfrom
improve-force-value-field-description
May 1, 2026
Merged

feat(force-value) - improve to use form description component#984
gabrielseco merged 4 commits intomainfrom
improve-force-value-field-description

Conversation

@gabrielseco
Copy link
Copy Markdown
Collaborator

@gabrielseco gabrielseco commented May 1, 2026

Extracting from #979, this change will be useful when I implement the whole functionality to transformHTMLToComponents prop

What this does is unify a description that was handled separately and have the same SSOT component


Note

Low Risk
Low risk UI refactor: consolidates forced-value description rendering onto shared BaseFormDescription and slightly adjusts Help Center link styling/props, with minimal behavior change beyond improved accessibility attributes.

Overview
Unifies ForcedValueField description rendering by reusing the shared BaseFormDescription component instead of a bespoke inline description/Help Center link implementation, and adds aria-labelledby/aria-describedby ids for better accessibility.

Extends the shared HelpCenter wrapper to accept a className, and refactors FormDescription into a thin wrapper around the newly exported BaseFormDescription so callers can supply custom ids when needed.

Updates the example onboarding config to include NLD (Netherlands) contract_details schema version mapping.

Reviewed by Cursor Bugbot for commit 5611ddf. Bugbot is set up for automated code reviews on this repo. Configure here.

@gabrielseco gabrielseco self-assigned this May 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 211.73 kB 211.33 kB +395 B (+0.2%) 🔴
Total (raw) 572.06 kB 570.58 kB +1.48 kB (+0.3%) 🔴
CSS (gzip) 20.69 kB 20.69 kB 0 B (0%) 🟢
CSS (raw) 107.95 kB 107.95 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 211.73 kB / 250 kB (84.7%)
  • ✅ Total raw: 572.06 kB / 600 kB (95.3%)
  • ✅ CSS gzipped: 20.69 kB / 25 kB (82.8%)

Largest Files (Top 5)

  1. chunk-SJZP5XKE.js - 13.93 kB (new)
  2. styles.css - 10.35 kB (0 B (0%))
  3. index.css - 10.35 kB (0 B (0%))
  4. index.js - 6.07 kB (+11 B (+0.2%))
  5. chunk-TNQKP2XT.js - 5.89 kB (0 B (0%))
View All Files (313 total)
File Size (gzip) Change
chunk-SJZP5XKE.js 13.93 kB new
styles.css 10.35 kB 0 B (0%)
index.css 10.35 kB 0 B (0%)
index.js 6.07 kB +11 B (+0.2%)
chunk-TNQKP2XT.js 5.89 kB 0 B (0%)
chunk-763JSZ5D.js 5.81 kB new
chunk-C2RPJGJB.js 4.55 kB new
chunk-Y7L6VZOT.js 4.29 kB new
chunk-DPVXTQAB.js 4.06 kB 0 B (0%)
chunk-TQQ227SJ.js 3.73 kB new

✅ Bundle size check passed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

📊 Coverage Report

⚠️ Coverage decreased

Metric Current Previous Change Status
Lines 89.95% 89.95% 0%
Statements 89.62% 89.62% 0%
Functions 87.69% 87.69% 0%
Branches 80.01% 80.07% -0.06% 🔴

Detailed Breakdown

Lines Coverage
  • Covered: 3651 / 4059
  • Coverage: 89.95%
  • Change: 0% (1 lines)
Statements Coverage
  • Covered: 3712 / 4142
  • Coverage: 89.62%
  • Change: 0% (1 statements)
Functions Coverage
  • Covered: 997 / 1137
  • Coverage: 87.69%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 2265 / 2831
  • Coverage: 80.01%
  • Change: -0.06% (-1 branches)

✅ Coverage check passed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-61bu5176v-remotecom.vercel.app
Latest Commit:5611ddf
Inspect:View deployment

Deployed with vercel-action

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit dd71f33. Configure here.

Comment thread src/components/form/fields/ForcedValueField.tsx Outdated
@gabrielseco gabrielseco merged commit 5b87b06 into main May 1, 2026
10 checks passed
@gabrielseco gabrielseco deleted the improve-force-value-field-description branch May 1, 2026 17:34
@gabrielseco gabrielseco mentioned this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants